Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to code-safe-2.2 #48

Merged
merged 5 commits into from
Oct 21, 2022
Merged

upgrade to code-safe-2.2 #48

merged 5 commits into from
Oct 21, 2022

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jul 10, 2022

Only to be merged when the other extensions of Lychee are also on Code Safe 2.2

@codecov
Copy link

codecov bot commented Jul 29, 2022 •
edited
Loading

Codecov Report

Merging #48 (be9d911) into master (49b29be) will decrease coverage by 2.13%.
The diff coverage is 93.83%.

Additional details and impacted files

@ildyria ildyria requested a review from a team October 20, 2022 13:18
nagmat84
nagmat84 requested changes Oct 20, 2022
View reviewed changes
Copy link

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only to minor changes regarding the use of the try-block.

Moreover, I don't know if I like this "infection" thingy. It seems to report a lot of code "improvement" which are actually none. IMHO, this is more of an annoyance than helpful.

.editorconfig Show resolved Hide resolved
.github/workflows/php.yml Show resolved Hide resolved
lib/PHPExif/Adapter/Exiftool.php Outdated Show resolved Hide resolved
lib/PHPExif/Adapter/FFprobe.php Outdated Show resolved Hide resolved
nagmat84
nagmat84 reviewed Oct 20, 2022
View reviewed changes
.github/workflows/php.yml Outdated Show resolved Hide resolved
@ildyria
Copy link
Member Author

ildyria commented Oct 21, 2022

@nagmat84 ? :)

@ildyria ildyria merged commit ada5def into master Oct 21, 2022
@ildyria ildyria deleted the code-safe-2.2 branch October 21, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagmat84 nagmat84 nagmat84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ildyria @nagmat84