Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composer update and test PHP 8.2 #57

Merged
merged 4 commits into from
Dec 21, 2022
Merged

composer update and test PHP 8.2 #57

merged 4 commits into from
Dec 21, 2022

Conversation

qwerty287
Copy link

To update PHPStan rules to latest ones.

@codecov
Copy link

codecov bot commented Dec 19, 2022 •
edited
Loading

Codecov Report

Merging #57 (32fd048) into master (bc0e753) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

@qwerty287 qwerty287 requested a review from a team December 19, 2022 18:05
@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@qwerty287 qwerty287 changed the title composer update composer update and test PHP 8.2 Dec 19, 2022
ildyria
ildyria approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ildyria
ildyria reviewed Dec 20, 2022
View reviewed changes
.github/workflows/php.yml
@@ -100,19 +100,7 @@ jobs:
php-version:
- "8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop 8.0 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another PR I'd say.

@qwerty287 qwerty287 merged commit 452546a into master Dec 21, 2022
@qwerty287 qwerty287 deleted the upd-phpstan branch April 6, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qwerty287 @ildyria