Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FFProbe keywords as String #68

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

dax
Copy link

@dax dax commented Apr 15, 2023

ffprobe version 4.4.2 returns a string for tags like com.apple.quicktime.keywords:

example:

    "format": {
        ...
        "tags": {
            ...
            "com.apple.quicktime.keywords": "keyword"
        }
    }

If the value is a string, this patch splits on a comma multiple keywords.

@sonarcloud
Copy link

sonarcloud bot commented Apr 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@qwerty287
Copy link

qwerty287 commented Apr 16, 2023

I think it would be good to have an end-to-end test for this, i.e. add a video file that has these keywords and then parse the file (also in addition to the current tests).

Or is this something specific for a version of ffprobe and not for a file?

@dax
Copy link
Author

dax commented Apr 18, 2023

@qwerty287 I don't think it comes from a specific file as I have used such files for a long time and it only recently stopped working. The only thing that has changed is Lychee and probably ffprobe.

@qwerty287 qwerty287 merged commit 94f2670 into LycheeOrg:master Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants