Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulls all emails, phone numbers (with their labels) - iOS and Android #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zibs
Copy link

@zibs zibs commented Nov 30, 2017

This may or not be an intended feature of this library, so I'm just throwing this PR up in case anyone is interested in it. This will fetch all the phone numbers and email addresses with their labels for both iOS and Android (instead of just the first one for the current library).

@mohamadswaidan
Copy link

Any chance you can accept this pull request? We really need this feature too.

@corysimmons
Copy link

@mohamadswaidan I forked and merged this here: https://github.com/corysimmons/react-native-contacts-wrapper

npm i react-native-contacts-wrapper-with-labels

@compojoom
Copy link

compojoom commented Apr 13, 2018

@corysimmons - you haven't merged the android changes. Your repository only contians the iOS changes.

@zibs - is there a reason why you've chosen different return types for iOS and Android?

on android one gets emails: [{address_type: ..., address: ...}]
on iOS we have emailAddresses: [{label: ..., email:... }]

that's confusing as one needs different code for ios and android.

@corysimmons
Copy link

@compojoom sorry, i thought i merged everything here but maybe i didn't? i was only dev'ing on iOS and have since become completely disinterested in React Native.

@nihp
Copy link

nihp commented Aug 6, 2020

Android payload giving duplicate number with this changes.

{

"name": "niph",
"phones": [{
"number_type": "mobile",
"number": "+183839732972372873"
}, {
"number_type": "mobile",
"number": "+183839732972372873"
}],
"emails": []
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants