Swift 3 #31
Swift 3 #31
Conversation
aCorrado
commented
Sep 15, 2016
aCorrado
commented
- Swift 3 Conversion
- Version Bump (probably we should go a major version here)
- Version Bump (probably we should go a major version here)
|
This is great but with the Travis file you need to add |
| @@ -1,5 +1,5 @@ | |||
| language: objective-c | |||
| osx_image: xcode7.3 | |||
| osx_image: xcode8.0 | |||
There was a problem hiding this comment.
I'm not sure on this but I think you need the value to be xcode8 and not xcode8.0
There was a problem hiding this comment.
You are perfectly right.
I'll add it and check why travis cannot find the simulator
There was a problem hiding this comment.
See #30 I think it works the best that way. We made changes to .travis.yml that got the tests to run.
There was a problem hiding this comment.
I've also found that we cals also use instead of
-sdk iphonesimulator9.3
this
-destination 'platform=iOS Simulator,name=iPhone 6s' CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO ONLY_ACTIVE_ARCH=NO
There was a problem hiding this comment.
Sure. I think we kept the 9.3 SDK to maintain the check in iOS 9 so we know it's still compatible with iOS 9
|
This also relies on RichTextVC which also needs the conversion. Looks like the failing is because the Example project still depends on that |
|
Weird, it passed validation but returned a 1. Can we figure out why? |
| script: | ||
| - set -o pipefail && xcodebuild test -workspace Example/LTMarkdownParser.xcworkspace -scheme LTMarkdownParser_Example -sdk iphonesimulator9.3 | xcpretty | ||
| - pod lib lint | ||
| - set -o pipefail && xcodebuild test -workspace Example/LTMarkdownParser.xcworkspace -scheme LTMarkdownParser_Example -sdk iphonesimulator9.3 -destination 'OS=9.3,platform=iOS Simulator,name=iPhone 5' | xcpretty |
There was a problem hiding this comment.
I think this shouldn't specify the iOS 9 simulator.
There was a problem hiding this comment.
From the log: "xcodebuild: error: SDK "iphonesimulator9.3" cannot be located."
|
@SerenadeX I think that error will go away with another |
|
Implemented in #33. |
