Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve getLocation when location service is disabled #267

Closed
wants to merge 4 commits into from
Closed

resolve getLocation when location service is disabled #267

wants to merge 4 commits into from

Conversation

nicowernli
Copy link

This is a fix for #210
Also fixes a typo in a variable and removed unused imports. This fix is Android only.

@nicowernli
Copy link
Author

Added also support for ios now. If you request getLocation and location services are disabled will throw an exception.

@Lyokone
Copy link
Owner

Lyokone commented Feb 16, 2020

Hey, sorry for the delay, I'm currently reviewing your changed :) Thanks :)

@Lyokone
Copy link
Owner

Lyokone commented Feb 18, 2020

Hey I close this PR, I've already merged your Android code in #284 with a lot of refactoring, I'll merge the iOS part in #287. Thanks for your help !

@Lyokone Lyokone closed this Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants