fix(ios): issue 621 - getLocation not resolving #625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems this issue is only happening if flutter is already requesting location updates when the call to getLocation is made. Potential fix: In the case where location updates are already running, and a valid location is already present, return the latest location to the caller when getLocation is called.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@Lyokone What do you think about this PR? |
|
Hi @ademanuele, would you be up to resolving the conflict? |
|
no response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #621
It seems this issue is only happening if flutter is
already requesting location updates when the call to
getLocation is made.
Potential fix:
In the case where location updates are already running,
and a valid location is already present, return the
latest location to the caller when getLocation is called.
I have tested this implementation and it seems to work on this dummy example app:
location.zip