Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to force LEFT-TO-RIGHT format in names? #22

Closed
frap129 opened this issue Jan 20, 2022 · 3 comments
Closed

Add option to force LEFT-TO-RIGHT format in names? #22

frap129 opened this issue Jan 20, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@frap129
Copy link

frap129 commented Jan 20, 2022 •
edited
Loading

I'm using sworkstyle with sway+waybar, and for some reason workspaces with Android Studio on them get their names reversed. Workspace 2 in this screenshot is an example
2022-01-20T08:23:18,024118821-05:00

Not sure if this is a sworkstyle problem or a waybar problem, bit it only happens with Android Studio. Nothing in the log at all
@frap129 frap129 changed the title Odd renaming, not sure of sworkstyle or waybar Reversed renaming, not sure of sworkstyle or waybar Jan 20, 2022
@frap129
Copy link
Author

frap129 commented Jan 21, 2022

Seems to be an issue with that specific icon forcing an RTL layout, must be a bug in nerd fonts

@frap129 frap129 closed this as completed Jan 21, 2022
@frap129
Copy link
Author

frap129 commented Jan 23, 2022 •
edited
Loading

@Lyr-7D1h Reopening because I found the issue and solution. Some glyphs in Nerdfonts patched fonts override arabic characters, which force RTL layouts by unicode standard. (Relevant nerdfonts bug, reported almost 2 and a half years ago).

My solution is to prepend names with U+202D (LEFT-TO-RIGHT OVERRIDE) and append with U+202C (POP DIRECTIONAL FORMATTING). I don't think that this should be applied universally so sworkstyle can still work for arabic users, but maybe a command line arg to enable wrapping of workspace names?

@frap129 frap129 reopened this Jan 23, 2022
@frap129 frap129 changed the title Reversed renaming, not sure of sworkstyle or waybar Add option to force LEFT-TO-RIGHT format in names? Jan 23, 2022
@frap129 frap129 mentioned this issue Jan 24, 2022
Closed
@Lyr-7D1h Lyr-7D1h added the enhancement New feature or request label Jun 17, 2022
@Lyr-7D1h
Copy link
Owner

As most people are English and use Sworkstyle with glyphs. I think it is safe to force use LTS for now. If there ever is a need to support RTS we could make this a configurable option. e792121 Implements this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frap129 @Lyr-7D1h