-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Commitizen and Husky hooks to the build pipeline #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a Husky pre-commit hook that runs lint-staged, which has been configured to run 'lint' and 'format' on the file types specified in .lintstagedrc. This helps the developer by only running the lint and format scripts on files they have changed and staged, and keeps unlinted and unformatted commits out of the code base. Resolves: #26
It appears that Husky no longer uses an object there. The hooks are all configured in the .husky folder. This object seems to be a leftover remnant in tutorials scattered around the internet.
These extra files were not needed, as semantic-release bundles everything anyway when run. No change to the end product.
I had originally intended 'build' to include all dependencies. I have realized that updating a project dependency (i.e. not a dev-dependency) should fall under 'fix'. 'build' can keep changes to dev dependencies, as contributing developers can still get those updates by just using git pull. However, an end user would have no ultimate behavioral change, and thus should not have to worry about retrieving the latest version.
This was originally added for the stress testing. It is no longer needed and is taking up resources.
Adds the commit body and footer sections. Also, verifies all the links work.
… in the class Additionally, updates the API.md file
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds additional build tools and documentation.
Pull Request Checklist
Please check if your PR fulfills the following requirements:
npm run build
) locally and pushed all changesIssues Addressed: #25, #26
Other Information
None