Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instantiating parameters using object in constructor #36

Merged
merged 5 commits into from
May 2, 2022

Conversation

M-Scott-Lassiter
Copy link
Owner

@M-Scott-Lassiter M-Scott-Lassiter commented May 2, 2022

Proposed Changes

Allows ability to use an optional config object in the constructor when instantiating the class.

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • I have read the CONTRIBUTING guidelines
  • My commits follow the appropriate guidance
  • I certify that I have the appropriate permissions to add these changes to the repository
  • An issue is open for the changes proposed
  • I have added/updated tests for new code changes (if applicable)
  • Documentation has been added/updated (if applicable)
  • I built (npm run build) locally and pushed all changes

Issues Addressed: #35

Other Information

None.

…bject in the constructor

This brings the class into line with other typical projects. Rather than having to set the
parameters with subsequent property calls, the user can go ahead and setup everything all at once.

Resolves: #35
@M-Scott-Lassiter M-Scott-Lassiter added the enhancement New feature or request label May 2, 2022
@M-Scott-Lassiter M-Scott-Lassiter self-assigned this May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #36 (11cf64c) into main (13035d4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           61        65    +4     
  Branches        13        16    +3     
=========================================
+ Hits            61        65    +4     
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13035d4...11cf64c. Read the comment docs.

@M-Scott-Lassiter M-Scott-Lassiter merged commit 093cdc8 into main May 2, 2022
@M-Scott-Lassiter
Copy link
Owner Author

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant