Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve member count. #45

Merged
merged 7 commits into from Feb 25, 2023
Merged

Conversation

M-Yamashita01
Copy link
Owner

The action counts github_membership and github_repository_collaborator in the tf file as members.
However, If a user starts writing the GitHub account management in a different way in the tf file, the action will not be counted correctly.
Therefore, I have improved the action to count members from terraform plan results.

lib/terraform_reader.rb Outdated Show resolved Hide resolved
lib/terraform_reader.rb Outdated Show resolved Hide resolved
lib/terraform_reader.rb Outdated Show resolved Hide resolved
lib/terraform_reader.rb Outdated Show resolved Hide resolved
lib/terraform_reader.rb Outdated Show resolved Hide resolved
spec/terraform_reader_spec.rb Outdated Show resolved Hide resolved
spec/terraform_reader_spec.rb Outdated Show resolved Hide resolved
spec/terraform_reader_spec.rb Outdated Show resolved Hide resolved
spec/terraform_reader_spec.rb Outdated Show resolved Hide resolved
spec/terraform_reader_spec.rb Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #45 (8e0709b) into main (1077d0e) will decrease coverage by 0.38%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   96.80%   96.42%   -0.38%     
==========================================
  Files          10        8       -2     
  Lines         250      224      -26     
==========================================
- Hits          242      216      -26     
  Misses          8        8              
Flag Coverage Δ
unittests 96.42% <100.00%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/check_members_action.rb 87.23% <100.00%> (ø)
lib/config_validator.rb 91.30% <100.00%> (ø)
lib/terraform_reader.rb 100.00% <100.00%> (ø)
spec/config_validator_spec.rb 100.00% <100.00%> (ø)
spec/terraform_reader_spec.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@M-Yamashita01 M-Yamashita01 merged commit 4b0855b into main Feb 25, 2023
@M-Yamashita01 M-Yamashita01 deleted the improve-member-count-in-terraform-files branch February 25, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants