Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.4.0-Alpha] Hardcoded paths in build #54

Closed
bastetfurry opened this issue Dec 23, 2018 · 7 comments
Closed

[0.4.0-Alpha] Hardcoded paths in build #54

bastetfurry opened this issue Dec 23, 2018 · 7 comments

Comments

@bastetfurry
Copy link

When trying to make the Makefile in the ./linux directory someone gets this result:

bastetfurry@katzenrechner:~/compile/EtherTerm/linux$ make
----------Building project:[ EtherTerm - Debug ]----------
make[1]: Verzeichnis „/home/bastetfurry/compile/EtherTerm/linux“ wird betreten
/usr/bin/g++  -c  "/home/blue/code/EtherTerm/src/input_handler.cpp" -g -O0 -pedantic -W -std=c++11 -Wall   -o ./Debug/up_src_input_handler.cpp.o -I. -I. -I.. -I../src 
g++: error: /home/blue/code/EtherTerm/src/input_handler.cpp: Datei oder Verzeichnis nicht gefunden
g++: fatal error: no input files
compilation terminated.
EtherTerm.mk:98: recipe for target 'Debug/up_src_input_handler.cpp.o' failed
make[1]: *** [Debug/up_src_input_handler.cpp.o] Error 1
make[1]: Verzeichnis „/home/bastetfurry/compile/EtherTerm/linux“ wird verlassen
Makefile:4: recipe for target 'All' failed
make: *** [All] Error 2

This fails because there are hardcoded paths in the Makefile.

@M-griffin M-griffin self-assigned this Dec 23, 2018
@M-griffin M-griffin added this to TODO in EtherTerm 4.0 Branch via automation Dec 23, 2018
@M-griffin
Copy link
Owner

M-griffin commented Dec 23, 2018

Hi Bastetfurry,

Sorry it's been a while and I've forgotten to make scripts that will clean the paths.
If you run this command from the root 'EtherTerm' folder:

sed -i 's+/home/blue/code/EtherTerm/src/+../src/+' linux/EtherTerm.mk

It will remove my hard coded paths for the current working folder, and this should get you going.

@M-griffin M-griffin pinned this issue Dec 23, 2018
@ftoledo
Copy link

ftoledo commented Apr 10, 2019

Replacing thats paths permit to compile. Thanks!

@M-griffin
Copy link
Owner

Note to self, add a make file command to clear local directory paths and use current working folder.

@M-griffin M-griffin moved this from TODO to WIP in EtherTerm 4.0 Branch Jul 9, 2019
@M-griffin M-griffin changed the title Hardcoded paths in build [0.4.0-Alpha] Hardcoded paths in build Jul 9, 2019
@M-griffin
Copy link
Owner

M-griffin commented Jul 11, 2019

This has now been corrected with the latest PR #58
Which now also includes some other Hot Fixes.

EtherTerm 4.0 Branch automation moved this from WIP to Completed Jul 11, 2019
@M-griffin M-griffin reopened this Jul 14, 2019
EtherTerm 4.0 Branch automation moved this from Completed to TODO Jul 14, 2019
@M-griffin
Copy link
Owner

Actually going to re-open this.
Windows, Linux, and OSX are now fixed. I still have to update FreeBSD once i get the VM up and running again. Once that is fixed i'll close this.

@M-griffin
Copy link
Owner

Windows, Linux and OSX builds should be all fixed. I'm working on a new FreeBSD VM install to update these makes files as time permits for master first, then i'll merged and rework for the later branches.

@M-griffin
Copy link
Owner

FreeBSD should be good now, And changes have been merged back to master. I should probably write up a quick text for install dependencies when i get a moment.

EtherTerm 4.0 Branch automation moved this from TODO to Completed Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
EtherTerm 4.0 Branch
  
Completed
Development

No branches or pull requests

3 participants