-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of commands quit
, scan
, monitor
and rpoplpush
for redisMock
#65
Conversation
quit
, scan
, monitor
and getProfile
for redisMock
827fb11
to
8dacb7d
Compare
*/ | ||
public function scan(): array | ||
{ | ||
return []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you return a empty array, how can you use the mock ? You should scan the dataValues and look into deleteOnTtlExpired.
/** | ||
* Mock the getProfile() | ||
*/ | ||
public function getProfile() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why getProfile ? is it a redis command ? Why do you return a ProfileMock ?
6e1361c
to
6efde52
Compare
quit
, scan
, monitor
and getProfile
for redisMockquit
, scan
, monitor
and rpoplpush
for redisMock
9179337
to
db74385
Compare
$values[] = $keysArray[$i]; | ||
} | ||
|
||
}else{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cs fixer
@@ -69,6 +69,7 @@ Redis command | Description | |||
**LRANGE** *key* *start* *stop* | Gets a range of elements from a list | |||
**MGET** *array\<field\>* | Gets the values of multiple keys | |||
**MSET** *array\<field, value\>* | Sets the string values of multiple keys | |||
**QUIT** | Quit the REDIS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a9e1104
to
c69b19d
Compare
fix s comment, syntax and style Improve version of predis ImAdd Method implementation and tests update the readme test tests... Fix old test remove useless predis/client method on the redis mock, add rpoplpush add constructorParameters and Scan command on redisMock Add comments and readme informations remove useless code Fix method definition after tests FiFix scan of redis mock FiFix style Reorder Readme list of functions Add the scan test and fix scan count Fix TTL test based from sleep... Fix TTL test based from sleep... Fix TTL test based from sleep... Fix TTL test based from sleep...
04b05ff
to
67c4384
Compare
Because I want to add few command on the REDIS mock
quit
commandrpolpush
methodscan
commandmonitor
command