Add support of commands quit, scan, monitor and rpoplpush for redisMock
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DocRoms
changed the title
quit, scan, monitor and getProfile for redisMock
DocRoms
force-pushed
the
feature/add-support-for-commands-and-profile
branch
from
827fb11
to
8dacb7d
Compare
fabdsp
reviewed
Mar 19, 2018
| */ | ||
| public function scan(): array | ||
| { | ||
| return []; |
There was a problem hiding this comment.
If you return a empty array, how can you use the mock ? You should scan the dataValues and look into deleteOnTtlExpired.
| /** | ||
| * Mock the getProfile() | ||
| */ | ||
| public function getProfile() |
There was a problem hiding this comment.
Why getProfile ? is it a redis command ? Why do you return a ProfileMock ?
DocRoms
force-pushed
the
feature/add-support-for-commands-and-profile
branch
from
6e1361c
to
6efde52
Compare
DocRoms
changed the title
quit, scan, monitor and getProfile for redisMockquit, scan, monitor and rpoplpush for redisMock
DocRoms
force-pushed
the
feature/add-support-for-commands-and-profile
branch
2 times, most recently
from
9179337
to
db74385
Compare
fabdsp
reviewed
Mar 22, 2018
| $values[] = $keysArray[$i]; | ||
| } | ||
|
|
||
| }else{ |
fabdsp
approved these changes
Mar 22, 2018
pabedu
reviewed
Mar 22, 2018
| @@ -69,6 +69,7 @@ Redis command | Description | |||
| **LRANGE** *key* *start* *stop* | Gets a range of elements from a list | |||
| **MGET** *array\<field\>* | Gets the values of multiple keys | |||
| **MSET** *array\<field, value\>* | Sets the string values of multiple keys | |||
| **QUIT** | Quit the REDIS | |||
There was a problem hiding this comment.
pabedu
approved these changes
Mar 22, 2018
DocRoms
force-pushed
the
feature/add-support-for-commands-and-profile
branch
4 times, most recently
from
a9e1104
to
c69b19d
Compare
fix s comment, syntax and style Improve version of predis ImAdd Method implementation and tests update the readme test tests... Fix old test remove useless predis/client method on the redis mock, add rpoplpush add constructorParameters and Scan command on redisMock Add comments and readme informations remove useless code Fix method definition after tests FiFix scan of redis mock FiFix style Reorder Readme list of functions Add the scan test and fix scan count Fix TTL test based from sleep... Fix TTL test based from sleep... Fix TTL test based from sleep... Fix TTL test based from sleep...
DocRoms
force-pushed
the
feature/add-support-for-commands-and-profile
branch
from
04b05ff
to
67c4384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I want to add few command on the REDIS mock
quitcommandrpolpushmethodscancommandmonitorcommand