Remove "version" from composer.json #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
This was added in #64 but it cause issues in our release process.
We're used to push a new tag on GitHub like
v3.0.0
and let Packagist's hook fetch this new tag on its side.But since there is a
version
key in ourcomposer.json
file, Packagist does not care about our tag, it only depends on ourversion
key... which is error prone (because I'm sure we'll forget to update theversion
key before tagging our new version).=> https://packagist.org/packages/m6web/statsd-bundle#3.0.0 proves that Packagist does not rely on our tags name anymore. (
3.0.0
vsv3.0.0
)How?
version
key fromcomposer.json