Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "version" from composer.json #66

Merged
merged 1 commit into from Apr 17, 2018
Merged

Remove "version" from composer.json #66

merged 1 commit into from Apr 17, 2018

Conversation

Oliboy50
Copy link
Member

@Oliboy50 Oliboy50 commented Apr 17, 2018

Why?

This was added in #64 but it cause issues in our release process.

We're used to push a new tag on GitHub like v3.0.0 and let Packagist's hook fetch this new tag on its side.

But since there is a version key in our composer.json file, Packagist does not care about our tag, it only depends on our version key... which is error prone (because I'm sure we'll forget to update the version key before tagging our new version).

=> https://packagist.org/packages/m6web/statsd-bundle#3.0.0 proves that Packagist does not rely on our tags name anymore. (3.0.0 vs v3.0.0)

How?

  • Remove the version key from composer.json

Copy link
Member

@Meroje Meroje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also from the documentation https://getcomposer.org/doc/04-schema.md#version

Note: Packagist uses VCS repositories, so the statement above is very much true for Packagist as well. Specifying the version yourself will most likely end up creating problems at some point due to human error.

@Oliboy50 Oliboy50 merged commit a9f9f46 into master Apr 17, 2018
@Oliboy50 Oliboy50 deleted the fix/remove-version branch April 17, 2018 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants