Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IEntityBase interface and update concrete class #168

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Add IEntityBase interface and update concrete class #168

merged 1 commit into from
Oct 28, 2021

Conversation

pedrolucasmr
Copy link
Contributor

@pedrolucasmr pedrolucasmr commented Oct 27, 2021 •
edited

Fixes #164

Added a interface for EntityBase and updates corresponding classes in order to use it. Now it's possible to take advantage of EF Core features that demand interfaces and not concrete classes.

PR checklist

  • Samples have been added/updated(Not Applicable)
  • Tests have been added/updated and pass(no new tests added)
  • Documentation has been added/updated for changes(Not Applicable)
  • Code styling has been met on new source file changes
  • Contains NO breaking changes

@pedrolucasmr pedrolucasmr requested a review from a team as a code owner October 27, 2021 01:20
jamesmcroft
jamesmcroft approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@jamesmcroft jamesmcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🚀

@jamesmcroft jamesmcroft merged commit 6ae92e3 into MADE-Apps:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmcroft jamesmcroft jamesmcroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add base interface for EF EntityBase class
2 participants
@pedrolucasmr @jamesmcroft