Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for generic ID for EF entity #275

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

jamesmcroft
Copy link
Member

Resolves #273

Added changes to support a generic ID for entity objects based on the EF Core library's IEntityBase interface.

Alterations have been made to the existing interfaces to ensure compatibility with upgrade. Introduced a generic interface and abstraction for IEntityBase and EntityBase.

To improve the usability of the extension methods that promoted the features of the EntityBase, the date components were further abstracted and re-implemented to ensure no breaking changes.

PR checklist

  • Have tests been added or updated, run locally, and all pass
  • Have code styling rules been run on all new source file changes
  • Have relevant articles in the docs been added or updated for all new source file changes
  • Have major breaking changes been made and are documented

Other information

@jamesmcroft jamesmcroft requested a review from a team as a code owner August 28, 2022 20:03
@jamesmcroft jamesmcroft merged commit ca05e64 into main Aug 29, 2022
@jamesmcroft jamesmcroft deleted the feature/273-entitybase-generic branch August 29, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support base EF entity with generic ID type
2 participants