Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added page object for web auth flow for Facebook #168

Merged
merged 3 commits into from
Oct 9, 2022
Merged

Added page object for web auth flow for Facebook #168

merged 3 commits into from
Oct 9, 2022

Conversation

jamesmcroft
Copy link
Member

Resolves #166

Adds a page object for the Facebook web authentication flow.

PR checklist

  • Have Legerity sample tests been added or updated, run locally, and all pass
  • Have added or updated support for platform specific element wrappers been reflected in the Page Object Generator
  • Have code styling rules been run on all new source file changes
  • Have relevant articles in the docs been added or updated for all new source file changes
  • Have major breaking changes been made and are documented

Other information

@jamesmcroft jamesmcroft requested a review from a team as a code owner October 9, 2022 18:19
@jamesmcroft jamesmcroft linked an issue Oct 9, 2022 that may be closed by this pull request
[Feature] Facebook login page object #166
Closed
@jamesmcroft jamesmcroft merged commit b30d3b4 into main Oct 9, 2022
@jamesmcroft jamesmcroft deleted the feature/166-facebook-login-pageobject branch October 9, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-made tom-made tom-made approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Facebook login page object
2 participants
@jamesmcroft @tom-made