Add support for configuring in storyboards and from a delegate #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `WelcomeSheetControllerConfigurator` and `WelcomeSheetControllerConfiguratorPageRow` to be able to configure WelcomeSheet entirely from Storyboards Remove fatalError from inis from coder Make WelcomeSheetPage conform to NSObject and have an objective-c runtime Change UIKit example
Rollback changes to UIKit-WelcomeSheetDemo Add model UIWelcomeSheetPage Add model UIWelcomeSheetPageRow Make `pages` an IBOutlet (Outlet collection)
Make WelcomeSheetController open Make ModalWelcomeSheetUIHostingController open Fix dismissal Add didDismiss to demo
…toryboard Change class to WelcomeSheetStoryboardController
Add assertionFailure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WelcomeSheetDelegateto configure pages and handledidDismissUIWelcomeSheetPageandUIWelcomeSheetPageRowThere is a problem with referencing system images from IB. As those are UIImages, passing them to Image makes them look stretched. See image. Not sure if there’s any way to fix this.
In progress