-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reservation error fix #339
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #339 +/- ##
==========================================
- Coverage 72.49% 72.38% -0.11%
==========================================
Files 113 113
Lines 3443 3455 +12
==========================================
+ Hits 2496 2501 +5
- Misses 947 954 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 😄 Would be great if you could add a test for when the duration of a reservation is 0, but this should be merged regardless 😊
I added the given test. Additionally, I fixed a bug in the template for editing reservations, that caused the datepicker for the start and end time of the reservation to be unusable. Finally, I added some custom error messages when creation of a reservation fails due to either a duration of 0 or not being covered by any rules. |
A fix for an error that occurs when a reservation is not covered by any rules. Currently, this causes an exception to be raised and sent in an email to the dev team. This fix, simply disallows reservations that are not covered by any rule, as is already the case.
I also included some tests to check these cases specifically, and some missing documentation for the involved methods.