Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for course registration search functionality #340

Merged
merged 2 commits into from
Mar 5, 2021

Conversation

zootos
Copy link
Contributor

@zootos zootos commented Mar 4, 2021

Fixes two issues:

  • Properly hides users that do not match search on mobile
  • Hitting enter on the keyboard or equivalently the "search" button on a mobile keyboard no longer triggers a download of a spreadsheet of the selected users. Instead, it takes focus away from the search field, i.e., as if the user finished their search. This should be a natural reaction from hitting enter/"search" when searching. For the spreadsheet, the download button must be used, as would be expected.

@zootos zootos requested review from ddabble and sigridge March 4, 2021 19:53
Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🔥

@zootos zootos merged commit 231fe7b into dev Mar 5, 2021
@zootos zootos deleted the fix/course-registration branch March 5, 2021 10:41
@sigridge sigridge mentioned this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants