Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug regarding manga volumes in discord rich presence #1019

Merged
merged 5 commits into from
Jan 17, 2022

Conversation

Gamesmes90
Copy link
Contributor

I found a bug regarding the rich presence.

I was testing the extension with Komga and found out that if the manga has "volume" or "volumes" tag, the rich presence will display "Chapter: 0 of X".

image

Checking for the volumes fixes the issue. I also called the "UI_Volume" directly.

image

Copy link
Member

@henrik9999 henrik9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are pages that have volume and chapter at the same time I would prefer that it shows the chapter number or maybe both instead then

@Gamesmes90
Copy link
Contributor Author

There are pages that have volume and chapter at the same time I would prefer that it shows the chapter number or maybe both instead then

Sorry, I didn't know that. I can try adding both. What pages can show both?

@Gamesmes90
Copy link
Contributor Author

Now it shows both volume and chapter number.

image

I changed "of" with a slash to save space when it shows both.

@lolamtisch
Copy link
Member

I think the chapter should be in front, as it is the more important metric. Would be annoying if it would cut of.

@Gamesmes90
Copy link
Contributor Author

Done.

image

@lolamtisch
Copy link
Member

I cleaned up the code.
I removed the untranslated "of".
And the totalchap/volume is only shown if there is one as the ? wasnt that helpfull in the presence

@lolamtisch lolamtisch merged commit 9432120 into MALSync:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants