Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Luminous Scans #1135

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Addition of Luminous Scans #1135

merged 3 commits into from
Jun 1, 2022

Conversation

mac5617
Copy link
Contributor

@mac5617 mac5617 commented May 27, 2022

No description provided.

@henrik9999
Copy link
Member

If this is the exact same code as realmscans it might be better to do something like this
https://github.com/MALSync/MALSync/blob/master/src/pages/EdelgardeScans/main.ts#L4
https://github.com/MALSync/MALSync/blob/master/src/pages/ZeroScans/main.ts#L5
We should really add support for themes like on tachiyomi or something

@mac5617
Copy link
Contributor Author

mac5617 commented May 27, 2022

Sure, I can change it

@mac5617
Copy link
Contributor Author

mac5617 commented May 28, 2022

What do you do when the original website shuts down or changes format? For example, zero scans changed their website a month or two ago and it seems like there are a few websites that link to it.

@henrik9999
Copy link
Member

What do you do when the original website shuts down or changes format? For example, zero scans changed their website a month or two ago and it seems like there are a few websites that link to it.

well you can see in #1137 what happens another site will just do it like i said its not really optimal and something like on tachiyomi would be better but someone has to do it

@lolamtisch lolamtisch merged commit 0243009 into MALSync:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants