Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM: Support PUSH and POP mnemonics #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Prcuvu
Copy link

@Prcuvu Prcuvu commented Jan 6, 2023

In ARM mode, PUSH reglist is a synonym for STMDB sp!, reglist and POP reglist is a synonym for LDMIA sp!, reglist. When reading disassembly, PUSH and POP are important markers for subroutine entry and return.

This commit adds support to these mnemonics.

References

@MAP233224
Copy link
Owner

I didn't know they were the preferred mnemonics at the time, apparently they changed their mind because in the original PDF they didn't use PUSH nor POP in the ARM version of the instructions. I'll review the code later and this will probably get merged soon after :)

@Prcuvu
Copy link
Author

Prcuvu commented Jul 11, 2023

Hello, it has been half a year. Is there anything blocking the review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants