MarketCollateralPool Test

[perfectmak]

Description

Tests for Market Collateral Pool minting, redeeming and settle and close.

Checklist

• Linter status: 100% pass
• Changes don't break existing behavior
• Tests coverage hasn't decreased

Refers/Fixes

Fixes: #159
Fixes: #160

[rojosnow]

@perfectmak Is this WIP PR tied to a specific issue? If so, go ahead and connect it to the PR. If not, set the Estimate and the current Milestone. Thanks!

[rojosnow]

I found the issue and connected it!

[0xean]

@perfectmak - rebase when you have a chance, everything is deploying properly and tests can now be ran.

The first basic minting test works, so hopefully, now your able to move forward without dealing with the complexities before!

[coveralls]

Pull Request Test Coverage Report for Build 652

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+6.5%) to 84.665%

---

Totals
Change from base Build 631:	6.5%
Covered Lines:	305
Relevant Lines:	343

---

💛 - Coveralls

[0xean]

@perfectmak - reviewing and changing removing WIP from title

[0xean]

@perfectmak this looks very good!

Nice work with how you are forcing the contracts to settlement, I think this is much cleaner than our old approach.

I think we are still missing a few tests. Let me confirm and add another comments if so.

[0xean]

@perfectmak should we do the same thing here for the long tokens to ensure it works for both sides (long, short) sides of the market.

[0xean]

some of these vars are no longer used, can we clean them up?

[perfectmak]

Sure, cleaning those up now.

[0xean]

Missing tests (I think)

• mintPositionTokens fails if market contract is already settled
• mintPositionTokens TokensMinted event is fired and correctly returns values
• redeemPositionTokens TokensRedeemed event is fired and correctly returns values
• settleAndClose burns the expected number of position tokens upon success
• settleAndClose TokensRedeemed event is fired and correctly returns values

I also think we should consider looking at the totalSupply_ of the erc20 short and long tokens to make sure that is being accounted for correctly, but perhaps @eswarasai is tackling that in his tests of PositionToken.sol

[eswarasai]

@pelsasser @perfectmak -- So the tests in regards with the PositionToken.sol are more of the duplicate to that of CollateralPool.test.js. It makes sense for me to have all the passing/failing tests in regards with the PositionToken to be under CollateralPool since it's the caller of the Long/Short Position Tokens. I'll try to tackle few of the above tests on this branch to breakdown the tasks. Thanks!

[CLAassistant]

All committers have signed the CLA.

[perfectmak]

@pelsasser I believe all the case should have been checked now. Kindly take a look.