GH-563: HOT-FIX - update Mumbai test token contract #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c20 and add contract test
…ine_signing_a_transaction_works_for_polygon_mumbai
dnwiebe
approved these changes
Feb 14, 2022
| "type": "function" | ||
| }]"#; | ||
| let abi = ethabi::Contract::load(min_abi_json.as_bytes()).unwrap(); | ||
| let contract = web3::contract::Contract::new(web3.eth(), address, abi); |
There was a problem hiding this comment.
This isn't critical, but I'd like to see a more descriptive name here. It's not really the contract, it's the pair of results from the two function calls. I understand that those two results are intimately connected with the contract, but they're not the same thing. Reading the code might be easier with a better name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.