Skip to content

Commit

Permalink
filterwarnings 'error' appears to break unit testing on windows
Browse files Browse the repository at this point in the history
  • Loading branch information
@bryan-harter
bryan-harter committed Feb 19, 2022
1 parent ab73945 commit fa6ae60
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion setup.cfg
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ docs =
minversion = 3.9
addopts = -ra --cov=cdflib --cov-report=xml
filterwarnings =
error
# Astropy emits various warnings when dealing with dates/times, which are
# not an issue
ignore:ERFA function
Expand Down

2 comments on commit fa6ae60

@dstansby
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What warnings are coming up? It's much safer to ignore the warning if it's an expected warning, that way we can catch other warnings that are not expected (like deprecation warnings from external packages)

@bryan-harter
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In github actions, it was saying "PytestUnraisableException" on the windows tests if we added this line in. Not sure what was going on! You can check out the last run that failed on Windows here: https://github.com/MAVENSDC/cdflib/runs/5257048133?check_suite_focus=true

According to a brief google, it might be fixed in a newer version of pytest?

Please sign in to comment.