Error on warnings during testing #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
force-pushed
the
warning-error
branch
2 times, most recently
from
0c9f3f5
to
3febdba
Compare
dstansby
force-pushed
the
warning-error
branch
3 times, most recently
from
62962f7
to
4523959
Compare
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 7 7
Lines 5133 5134 +1
======================================
- Misses 5133 5134 +1
Continue to review full report at Codecov.
|
dstansby
force-pushed
the
warning-error
branch
from
358a836
to
317e2fb
Compare
dstansby
force-pushed
the
warning-error
branch
from
317e2fb
to
bf44be6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we'll need to add additional commits here to make the windows build pass. But lets see what the error is to start with.