Fixed updating entires with plural form #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated Parser::updateEntry() - added Parser::updateEntries() - refactored removing fuzzy from Parser::updateEntry() into Parser::removeFuzzyFlagForMsgId() - added tests
| unset($flags[array_search('fuzzy', $flags, true)]); | ||
| $this->entriesAsArrays[$original]['flags'] = $flags; | ||
| /** | ||
| * Allows modifaction of all translations of an entry |
|
@dhm80 Thanks for this PR. Have you tested if file saved with this code can be opened in |
|
@MAXakaWIZARD No problem, glad to help. I changed the exception messages, corrected the typo and used And: Yes, the generated .po file works like charm in poEdit. I just testet that. Did you have any problems? |
MAXakaWIZARD
added a commit
that referenced
this pull request
Nov 19, 2015
Fixed updating entires with plural form
|
@dhm80 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plural form could not be saved when using
updateEntrymethod (plural form was deleted).Here is a fix for that.