Fix fetching translations for github actions #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the way the translation job fetches and stores translations in the cache. When translations are fetched, the repository is included in the cache, therefore we need to skip the checkout step in the build job. Otherwise, run the checkout step. Also clean up comments.
Use the correct context for the build conditional
I can't spell my name right
Accidentally using an old version of the job.
Remove my repository from the translation fetch (to simulate fetching from a different repository from MCC)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #2424.
This PR makes the following changes:
The translation cache is actually a crucial part of the system, as fetching the translations per build in parallel is not allowed by the Crowdin API, and returns an error.