Fix plot crashing on /plot visit [anything here] 0, issue #72 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StackDoubleFlow
requested changes
Dec 11, 2023
| @@ -98,7 +98,7 @@ impl Plot { | |||
|
|
|||
| let idx = if args.len() == 2 { | |||
| match args[1].parse::<usize>() { | |||
| Ok(idx) => idx - 1, | |||
| Ok(idx) => idx.wrapping_sub(1), | |||
There was a problem hiding this comment.
wrapping_sub here probably isn't right. I'd imagine we want to send an error message if idx is 0 since that's not a valid plot id.
There was a problem hiding this comment.
It will send the Plot range (1, {}). message unless someone has usize::MAX plots which is already impossible due to memory limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.