Allow buttons to work on monitors #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it's actually tested.
ghost
tkbstudios
approved these changes
Mar 25, 2024
MCJack123
requested changes
Mar 25, 2024
|
Actually now it requires the monitor argument, should I leave it like that or see if the window is a monitor and use that? |
|
True, I would prefer if you auto-detect monitors through |
|
I love github mobile bugs. |
|
Finally got around to doing it, also fixed a typo that broke everything (oops). |
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not actually sure how well this works, I'll have to test it more.
I've also made this in around 15 minutes, so it's not tested much.
Should this use the button component or be split into a different one?
Fixes #4 (i think)
Closes #5