Version Number

[Taupe]

Hey,

I'm getting this pop-up every time I try to start NSO-RPC telling me to enter the App Store version of the NSO Mobile App. After entering the correct version (2.10.0 as of May 8, 2024), nothing happens.

[Jiralite]

The reason why nothing happens is because of this:

NSO-RPC/client/api/__init__.py

Lines 99 to 102 in f6e683f

	def __init__(self, session_token, user_lang, targetID, version):
	pattern = re.compile(r'(\d.\d.\d)')
	if not version or not re.search(pattern, version):
	raise Exception('missing app version')

2.10.0 does not match \d.\d.\d due to it only accepting a singular digit (. itself not being escaped is a separate issue).

The actual cause of this issue is actually from the same check:

NSO-RPC/client/api/__init__.py

Lines 63 to 77 in f6e683f

	def getVersion():
	for i in range(5):
	try:
	r = requests.get('https://apps.apple.com/us/app/nintendo-switch-online/id1234806557', timeout = 10)
	break
	except requests.RequestException as e:
	log(f'Failed to get Apple\'s store page. Retrying... Error: {str(e)}')
	else:
	log('Failed to get Apple\'s store page after multiple retries.')
	if r:
	searchPattern = re.compile(r'Version\s*(\d\.\d\.\d)+')
	version = searchPattern.search(r.text)
	if version:
	return version.group(1)
	return ''

[HotaruBlaze]

I'm already aware of this and dealt with it here: #145

either do 2.9.1 and hope it wont crash, or use this build for now: https://github.com/HotaruBlaze/NSO-RPC/releases/tag/dev-ovr-2.9.1-HotaruBlaze

[Taupe]

Thanks!