Multiple bugfixes and tweaks around Github actions. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Spotlight <spotlight@joscomputing.space>
This was referenced May 10, 2024
|
Updated PR with more tweaks, Below is a build https://github.com/HotaruBlaze/NSO-RPC/releases/tag/dev-%23145-hotarublaze-v2 |
HotaruBlaze
changed the title
HotaruBlaze
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Merges PR's #145 #142 #139 to be a cleaner initial merge.
This also resolves issues: #146 #140 #144
[API] Handle imink API being down: Actually print an error when imink is down, instead of the previous timestamp error.
[API] Fix getVersion discrepency causing an error: Theirs a mismatch between the regex's in app.py and the cli init, This replaces then with a function dedicated to the regex for both sides.
[Github] Update actions and cleanup job ordering: Updates the action images, Also reorganized the jobs matrix to be cleaner.
[Github:MacOS] Use venv for macos building.: Github updated their MacOS image, requiring venv to build correctly. (Thanks to @spotlightishere for the simple fix!)
Edit: This has been updated to include more changes, listed below.
[Github:MacOS] Add test for macos: This should hopefully catch initial errors such as QT bindings being missing, however only checks if the app launches correctly.
[Github:MacOS] Install pyqt6 inside of venv: We forgot to add pyqt6 to the venv during builds.
[Github] Pin versions and Support PR's: Pinned the github images to specific versions,
Note: We are currently unable to build using macos 14 or macos 13.
MacOS 14 on Github Actions is arm64 only, and we are unable to build a working x64 build on it.
MacOS 13 has a packaging issue that i couldn't get working Suspected issue here, and the suggested fixes do not work.
MacOS 12 still seems to work for now.
This commit also enabled testing PR's before merging, however could become a spam issue on discord in the future, we will need to wait and see.
[Github] Dont include the test output.log file: This is a leftover file from the new MacOS test script that's accidently included in builds.
[Fix] Update _version.py to handle tags and PR's correctly: Fixes the logic where tags can be ordered incorrectly or fails to find the correct tag due to it being a PR.
[Github:MacOS] Fix typo in curl: when updating actions and updating this PR, i made a typo in the script for the action.