Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixed PR] Add na_id and fix hash_method header. #77

Merged
merged 1 commit into from
May 26, 2023

Conversation

HotaruBlaze
Copy link
Contributor

Recently their was a change that broke Nintendo f-generation, This has mostly been fixed however theirs still some downtime issues with imink, that may need extra attempts before failing.

However this PR adds the na_id that is recommended to be send now for the new f-generation, and I believe I've implemented it correctly, These changes are noted here: samuelthomas2774/nxapi#10 (comment)

Note, NSO-RPC does in fact currently work again, however this is more future proofing.

I also noticed when doing this that hashMethod got changed awhile ago, and its meant to be hash_method, however the old way was still supported, so i decided to update the header.

Edit: I remade the PR because I noticed a issue with the previous one, and i had to rewrite the commit.

@MCMi460
Copy link
Owner

MCMi460 commented May 26, 2023

Epic, thank you!
Also, whenever you find an issue with a PR that you'd like to fix without making another commit, just rebase to that branch and make whatever changes necessary, that way the PR remains intact and is only serving the commit that you want.
At least, that's how I think it works. I pray that the Github Overlords do not smite me or thee, if this advice is malproposed. (not a word)

@MCMi460 MCMi460 merged commit 45e0bed into MCMi460:development May 26, 2023
@HotaruBlaze
Copy link
Contributor Author

My issue was also that I had closed the PR while i was fixing it, forgetting i cant reopen the PR because of github permissions, Mainly because I'm too used to only managing my own stuff

@HotaruBlaze HotaruBlaze deleted the NSO-na_id branch May 26, 2023 14:44
@MCMi460
Copy link
Owner

MCMi460 commented May 26, 2023

Oh, okay, I see.
Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants