Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.androidVolume.setMusic(f,false); still give a toast #4

Closed
luigi37 opened this issue Jan 27, 2018 · 5 comments
Closed

window.androidVolume.setMusic(f,false); still give a toast #4

luigi37 opened this issue Jan 27, 2018 · 5 comments

Comments

@luigi37
Copy link

luigi37 commented Jan 27, 2018

As per title... it seems the toast is anyway issued...

@MCluck90
Copy link
Owner

That's so strange. Someone posted about that before and I'm still confused as to why that's the case. I'll try to look into it sometime soon.

@luigi37
Copy link
Author

luigi37 commented Jan 29, 2018

Mike give a look at js setvolume.
It seems if parameters are less than 4 you have set toast to true...

@luigi37
Copy link
Author

luigi37 commented Jan 29, 2018

That would explain other user's post behaviour

@MCluck90
Copy link
Owner

Oh yeah, I guess so. I remember doing that now. The thinking was that it would default to showing it because this originally was just meant for me as part of a weekend project. That'll be an easy fix to make.

@luigi37
Copy link
Author

luigi37 commented Jan 31, 2018

Cool, thanks :-)

MCluck90 added a commit that referenced this issue Feb 5, 2018
@MCluck90 MCluck90 closed this as completed Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants