Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Raider" Behavioural characteristic #4371

Open
wants to merge 82 commits into
base: master
Choose a base branch
from

Conversation

Spectrall368
Copy link
Collaborator

@Spectrall368 Spectrall368 commented Nov 6, 2023

This PR adds a new behavioural characteristic
GUI Example:
image

A new option, which entities will now be able to spawn in raids
GUI Example:
image

and a new field to select the raid celebration sound
GUI Example:
image

This feature was requested in the NeoToolkit discord server:

image

For the MCreator Changelog:

  • Added a new behavioral characteristic called "Raider"
  • Added a new option for entities to spawn in the raid
  • Added a new option to select the celebration sound of the entity winning a raid

@Spectrall368 Spectrall368 added new feature New feature or request community review Used by maintainers to mark issues that should get community reviews, tests, and feedback labels Nov 6, 2023
@Spectrall368 Spectrall368 changed the title Can spawns in Raid Option for Entities Spawn in Raid Option for Entities Nov 6, 2023
@Spectrall368 Spectrall368 marked this pull request as draft November 6, 2023 22:08
…o needs to be added to 1.20.1)

Co-authored-by: Goldorion <38427877+Goldorion@users.noreply.github.com>
Co-authored-by: Goldorion <38427877+Goldorion@users.noreply.github.com>
@MISMASJETU
Copy link
Contributor

I know its a work in progress, but don't forget to add some kind of menu, where you can select number of mobs per wave.

I wanted to implement this few months ago, but had no idea how to make it interface-vise.

(Also kinda funny to see the comments about some of the code, since I was the one who gave it to him XD)

Copy link
Contributor

@KlemenDEV KlemenDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be another mobBehaviourType = new JComboBox<>(new String[] { "Mob", "Creature" }); instead and when selected, disable fileds that don't work in combination with this one

@KlemenDEV
Copy link
Contributor

Waiting for PR author to do the rest of the fixes, I currently don't have time to do more work on this PR

@Spectrall368 Spectrall368 marked this pull request as ready for review April 12, 2024 15:26
@KlemenDEV
Copy link
Contributor

Raider entities also need to be tagged under the right tags. Use autotags for this

@KlemenDEV KlemenDEV marked this pull request as draft April 14, 2024 13:49
@Spectrall368 Spectrall368 marked this pull request as ready for review April 15, 2024 13:18
Copy link
Contributor

@KlemenDEV KlemenDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I use any AI base and select a raider type, the build straight-up fails.

This PR needs much much more testing.

For this particular case, one option would be to disable AI bases if raider type is selected.

@KlemenDEV KlemenDEV marked this pull request as draft April 15, 2024 18:19
@Spectrall368
Copy link
Collaborator Author

If I use any AI base and select a raider type, the build straight-up fails.

This PR needs much much more testing.

For this particular case, one option would be to disable AI bases if raider type is selected.

Done

@Spectrall368 Spectrall368 marked this pull request as ready for review April 15, 2024 19:09
@KlemenDEV KlemenDEV marked this pull request as draft April 15, 2024 19:31
@Spectrall368 Spectrall368 marked this pull request as ready for review April 20, 2024 21:20
@KlemenDEV KlemenDEV marked this pull request as draft April 21, 2024 08:41
@Spectrall368 Spectrall368 marked this pull request as ready for review April 26, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community review Used by maintainers to mark issues that should get community reviews, tests, and feedback new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants