Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to display model layers' hurt animation #4436

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Option to display model layers' hurt animation #4436

wants to merge 12 commits into from

Conversation

Defeatomizer
Copy link
Collaborator

Adds an option to model layers that controls if they are affected by parent entity taking damage.

2 question that require the draft state:

  1. Should the parameter be inverted?
  2. (Remembering the previous question) What is the appropriate name for the parameter in definition/UI?

@Defeatomizer Defeatomizer mentioned this pull request Dec 14, 2023
Merged
@Defeatomizer Defeatomizer added the new feature New feature or request label Dec 14, 2023
@Defeatomizer
Copy link
Collaborator Author

I am actually surprised by how minor the PR turned out to be, just 7 files with +19 and -4.

@Defeatomizer Defeatomizer marked this pull request as ready for review December 14, 2023 19:38
@KlemenDEV
Copy link
Contributor

Please sync with the master as diff is not correct for the current master branch:

image

@KlemenDEV KlemenDEV marked this pull request as draft December 27, 2023 16:24
@KlemenDEV KlemenDEV marked this pull request as ready for review December 28, 2023 07:52
@KlemenDEV
Copy link
Contributor

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Do not remove this label manually, it should be removed by the bot when new activity occurs.

@github-actions github-actions bot added the stale Stale issue label Jan 31, 2024
@KlemenDEV KlemenDEV removed the stale Stale issue label Jan 31, 2024
@Defeatomizer Defeatomizer added the on hold Used to mark PRs that are blocked by another PR or not on the nearby roadmap label Feb 1, 2024
@Defeatomizer Defeatomizer removed the on hold Used to mark PRs that are blocked by another PR or not on the nearby roadmap label Mar 9, 2024
@KlemenDEV KlemenDEV added the community review Used by maintainers to mark issues that should get community reviews, tests, and feedback label Mar 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Do not remove this label manually, it should be removed by the bot when new activity occurs.

@github-actions github-actions bot added the stale Stale issue label Apr 24, 2024
@KlemenDEV KlemenDEV removed the stale Stale issue label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spectrall368 Spectrall368 Spectrall368 approved these changes

@KlemenDEV KlemenDEV Awaiting requested review from KlemenDEV

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community review Used by maintainers to mark issues that should get community reviews, tests, and feedback new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Defeatomizer @KlemenDEV @Spectrall368