Particle scaling

[Spectrall368]

With this PR, the particles will be able to have a variable size

Example:

For the MCreator Changelog:

• Added a new number procedure selector for particle scaling

[KlemenDEV]

This component looks really non-standard compared to how procedure selectors look like:

Please resolve this

[Spectrall368]

This component looks really non-standard compared to how procedure selectors look like:

Please resolve this

What do you mean?

[KlemenDEV]

Check how this component looks in other parts of UI. It has border and background, while yours looks different

[Spectrall368]

Check how this component looks in other parts of UI. It has border and background, while yours looks different

I copied the selector code from that of the living entities, I don't understand how it can be different

[KlemenDEV]

See, in other parts, it has a background:

I did not check code yet, but I suspect you either override bg or opacity settings when you shouldn't

[Spectrall368]

This component looks really non-standard compared to how procedure selectors look like:

Please resolve this

Fixed!

[Spectrall368]

See, in other parts, it has a background:

I did not check code yet, but I suspect you either override bg or opacity settings when you shouldn't

Fixed!

[KlemenDEV]

There is still change we don't want

[KlemenDEV]

Please see https://github.com/MCreator/MCreator/pull/4720/files tab to see it in action

[KlemenDEV]

Seems this PR was not tested enough yet.

This is a particle with the scale 1:

And this is same particle if I use number procedure that always returns 1:

To me, this does not look like the same size, despite me setting scale to 1 effectively in both cases (fixed value vs procedure returning same fixed value).

Please investigate this, fix it, and do another round of careful testing (not just this problem, but whole system carefully, including dynamic sizing and stuff like that).

[NerdyPuzzle]

Seems to be due to the quad size being modified instead of the multiplier (size), the return value probably needs to be multiplied by the scale variable the overriden method provides. (I didn't test that, it's just a theory from a quick look I took from my phone)

[KlemenDEV]

Your fixes are getting really messy. Also why two commits?

Please test locally and commit once you are sure you fixed the problem

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Do not remove this label manually, it should be removed by the bot when new activity occurs.