[1.20.6] Ported Enchantment Types datalist #4827
Conversation
Spectrall368
added
the
on hold
Spectrall368
removed
the
on hold
|
When doing porting, please respect our rules that require you to move file from ref-* generator in one step and then do changes in the other so diff can be clearly seen. Thanks! |
|
You will likely need to close PR and open new one where you first move files and then apply changes. You can store mappings file locally, revert, copy from ref, commit, and then put your file backup back and make another commit |
Spectrall368
force-pushed
the
map_ench_types
branch
from
010d8ac
to
562be4d
Compare
I did it in this commit |
|
you deleted the file, not moved it, that is why it is shown as deletion and not as move |
I did it with all the other PRs |
|
Well here you see move is not correctly registered so please correct this. Thanks! |
|
@Spectrall368 maybe try re-doing the PR if GH does not want to show this correctly in this one |
|
I am closing this PR as this should be done together with enchantment ME so the mappings make sense together with new template |
| @@ -0,0 +1,58 @@ | |||
| _default: DIGGER | |||
There was a problem hiding this comment.
I know this is closed, but for future reference, default value needs provide same number of mapping tables as other entries, 2 in this case
Ported Ench. Types mapping (since a lot has changed in enchantments, this is the best way I've found to maintain the same enchantment gui and mapping for the other versions)