-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New externalized dialogs (part 2/2) #565
New externalized dialogs (part 2/2) #565
Conversation
Merge branch 'master' into localization-two
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise seems fine. I will wait for a review from @MysteriousWolf to check strings and key names and he will then merge it as usually ;)
Merge branch 'master' into localization-two
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the comments
src/main/java/net/mcreator/ui/dialogs/TextureMappingDialog.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will merge
This PR externalize new dialogs: