add --config parameter to allow specifying a configuration file #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json formatted config file. Default to config.json, given as an example file in the repo. Additionally, it doesn't create a temporary CSV file anymore. It checks the GoPhish API if a group with the same name exists, and if so, updates it, otherwise creates a new group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing to specify a configuration file allows multiple cron jobs, or a wrapper around the script to create a number of groups in GoPhish based on different LDAP filters.
The --config parameter defaults to the given config.json.
Updated the documentation to reflect the changes, and document the config file parameters.
While there, as it seems easier to handle, I changed the way GoLDAP works. It doesn't create an
intermediary CSV file anymore. It uses the ldap_to_gophish_mapping to create a JSON blob from the
attributes retrieved from LDAP. It then checks the GoPhish API if a group with the same name already
exists, if not, it's POSTing to create a new group, otherwise PUTing to update the existing group.
Updated README.md to reflect the changes.
Hope you like it, let me know if I shall change/update some bits here or there.
If you don't like it, feel free to dismiss the MR.