Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for "big" fetch_*() functions #17

Closed
orbeckst opened this issue Oct 11, 2018 · 2 comments
Closed

tests for "big" fetch_*() functions #17

orbeckst opened this issue Oct 11, 2018 · 2 comments
Assignees

Comments

@orbeckst
Copy link
Member

We should test all fetch_*() functions/datasets (see #6 and PR #16 ). The "big" datasets have sizes > ~150 MB and download takes a long(ish) time.

We should find a way to mock-out the download or replace it with something tiny. It would nevertheless be good to ascertain that the download URLs are still valid (e.g. by download the first few bytes).

@orbeckst
Copy link
Member Author

@richardjgowers I tentatively assigned you as the King of Mocks. I don't think that this is super-urgent but I wanted an open issue as a reminder (as opposed to a discussion on closed #6).

@orbeckst
Copy link
Member Author

This has been addressed by marking most of the dataset fetch tests online: test with

pytest -m online

to run them.

Perhaps we can make this a cron job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants