Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need tests #6

Closed
orbeckst opened this issue Oct 2, 2018 · 3 comments · Fixed by #15
Closed

need tests #6

orbeckst opened this issue Oct 2, 2018 · 3 comments · Fixed by #15

Comments

@orbeckst
Copy link
Member

orbeckst commented Oct 2, 2018

Need tests that run on travis.

Downloading data as part of the tests might be expensive for big datasets but we should do something.
@orbeckst
Copy link
Member Author

orbeckst commented Oct 5, 2018

As part of #4,Travis CI was enabled. The library is being installed but not tested.

This was referenced Oct 10, 2018
Merged
Merged
orbeckst added a commit that referenced this issue Oct 11, 2018
@orbeckst
initial tests for functions in base
0508513 
- start #6
- tests for
  - _read_description()
  - _sha256()
  - _fetch_remote()
  - get_data_home()
@orbeckst orbeckst mentioned this issue Oct 11, 2018
Merged
@orbeckst orbeckst mentioned this issue Oct 11, 2018
Merged
@richardjgowers
Copy link
Member

@orbeckst wrt more tests, I was thinking we could mock the call that does the download. So stop it just before it downloads. Then mock the file exists check too etc

@orbeckst
Copy link
Member Author

Mock is probably the way to go.

I will merge #16 as a "bonda fide" test (it ran pretty fast) and then we should look into mocking.

@orbeckst orbeckst mentioned this issue Oct 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

initial tests MDAnalysis/MDAnalysisData
2 participants
@orbeckst @richardjgowers