Functional refactoring of save branch

[joaomcteixeira]

@PicoCentauri
At the end I did not want to commit directly to the save branch. So I am doing a Pull Request to your branch 😄 🐰 💊

I have refactored the save.py. Made the save_results kind of a pipeline approach. I think it reads great. There is no new algorithm. I have built on top of your implementations. This refactor will facilitate testing.

I am not finished yet, tests are still missing. But in this way you can comment on what I am doing.

[PicoCentauri]

One thing I would like to do when I wrote this function is not to restrict this to one list and an extra list but apply the operations on list_1D to a series of lists. The function definition could be something like

def stack_1d_arrays_list(list_1D, *args):
    """
    Stack a list of 1D numpy arrays of the same length vertically together.    

    The result is a list containing 2D arrays where each array got the same    
    number of rows. Yo can apply additional lists of 1d arrays as extra arguments. 
    The operations applied to the first are also applied to the 
    consecutive lists of arrays.

    Parameters    
    ----------    
    list_1d : list
       list of 1 dimensional numpy arrays

    ...
    """

[joaomcteixeira]

I haven't changed that function. I am not sure yet about what you mean. I will look to it carefully later and "discord" with you. Anyway, we are meeting today at 11PM, right?

[PicoCentauri]

Yes lets discuss this on discord. I can also take a look at this later.

[joaomcteixeira]

I think we should address this on the save branch

[PicoCentauri]

I like the new structure. Just one thing I had in mind: Why is there a save_1D_array and a save_results_array function? Can't these two be combined? Or at least the names are confusing. Which function should I use when I have an arbitrary array?

[joaomcteixeira]

I like the new structure. Just one thing I had in mind: Why is there a save_1D_array and a save_results_array function? Can't these two be combined? Or at least the names are confusing. Which function should I use when I have an arbitrary array?

I will solve this. Nice comment +1

[joaomcteixeira]

I think this is done.
If you like it we can merge to the save branch.

[joaomcteixeira]

I like the new structure. Just one thing I had in mind: Why is there a save_1D_array and a save_results_array function? Can't these two be combined? Or at least the names are confusing. Which function should I use when I have an arbitrary array?

I addressed this.