Several changes to infractstructure #96
Conversation
PicoCentauri
commented
Apr 8, 2022
PicoCentauri
commented
- Fix isort dependency
- Added tests for Python 3.10
- Introduce new setup.cfg and pyproject.toml
- Update authors
PicoCentauri
force-pushed
the
setupcfg
branch
3 times, most recently
from
10eba9a
to
bb66cdc
Compare
Codecov Report
@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 83.09% 83.15% +0.06%
==========================================
Files 8 8
Lines 550 552 +2
Branches 104 109 +5
==========================================
+ Hits 457 459 +2
+ Misses 76 75 -1
- Partials 17 18 +1
Continue to review full report at Codecov.
|
* Fix isort dependency * Added tests for Python 3.10 * Introduce new setup.cfg and pyproject.toml * Update __authors__
| license = GPLv3 | ||
| license_files = LICENSE | ||
| url = https://github.com/MDAnalysis/mdacli | ||
| author = attr:pycoulomb.__authors__ |
There was a problem hiding this comment.
Never seen this. Can you explain to me, please?
There was a problem hiding this comment.
This is a nice feature of the 'new' cfg files. Probably works only for pure python package but us it is nice! It allows certain special directives:
attr: - Value is read from a module attribute. attr: supports callables and iterables; unsupported types are cast using str().
In order to support the common case of a literal value assigned to a variable in a module containing (directly or indirectly) third-party imports, attr: first tries to read the value from the module by examining the module’s AST. If that fails, attr: falls back to importing the module.
file: - Value is read from a list of files and then concatenated
| * Fix isort dependency | ||
| * Added tests for Python 3.10 | ||
| * Introduce new setup.cfg and pyproject.toml | ||
| * Update __authors__ |
There was a problem hiding this comment.
Where are the new authors?
There was a problem hiding this comment.
There are no new, but I just changed the list in the init.py file
|
@joaomcteixeira do you know why RTD is not finding MDAnalysis? And why the build test is now failing? EDIT: Fixed it |
|
Hello @PicoCentauri! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-04-12 13:31:50 UTC |
| license = GPLv3 | ||
| license_files = LICENSE | ||
| url = https://github.com/MDAnalysis/mdacli | ||
| author = attr:pycoulomb.__authors__ |
Several changes to infractstructure (#96) * Fix isort dependency * Added Python 3.10 * Introduce new setup.cfg and pyproject.toml * Update __authors__ * Add py3.10 to classifiers * Cleanup RTD conf
