Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update maintainers #48

Merged
merged 1 commit into from
Nov 6, 2023
Merged

update maintainers #48

merged 1 commit into from
Nov 6, 2023

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Nov 3, 2023

Fixes #47 (partially)

Changes made in this Pull Request:

  • part of adding new ENCORE maintainers #47
  • add new maintainers in pyproject.toml
  • updated author list in pyproject.toml: explicitly list the original
    ENCORE authors and Ian (for his work in porting mdaencore), list everyone
    else implicitly as "mdaencore AUTHORS"
  • changed maintainer to @enoee
  • updated author in setup.py to be the maintainer + AUTHORs but uses
    @enoee s email; as far as I can tell, the PyPi page will use the better
    metadata from pyproject.toml so it should be fine

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@orbeckst
Copy link
Member Author

orbeckst commented Nov 3, 2023

oops... sorry, need to clean up this branch

@orbeckst orbeckst force-pushed the update-maintainers branch 2 times, most recently from 423343a to 9a3881f Compare November 3, 2023 00:31
- part of #47
- add new maintainers in pyproject.toml
- updated author list in pyproject.toml: explicitly list the original
  ENCORE authors and Ian (for his work in porting mdaencore), list everyone
  else implicitly as "mdaencore AUTHORS"
- changed maintainer to @enoee
- updated author in setup.py to be the maintainer + AUTHORs but uses
  @enoee s email; as far as I can tell, the PyPi page will use the better
  metadata from pyproject.toml so it should be fine
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #48 (83e9a84) into main (ce16a18) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@orbeckst orbeckst merged commit b0772b7 into main Nov 6, 2023
24 checks passed
@orbeckst orbeckst deleted the update-maintainers branch November 6, 2023 18:06
@orbeckst
Copy link
Member Author

orbeckst commented Nov 6, 2023

thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding new ENCORE maintainers
4 participants