Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly resolve path to the logo and favicon #22

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

ianmkenney
Copy link
Collaborator

- use `pathto(..., 1)` instead of a raw path
  for both the favicon and logo in layout.html
- fixes MDAnalysis#21
Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for noticing and fixing this @ianmkenney!

@ianmkenney ianmkenney merged commit 5312fd2 into MDAnalysis:main Aug 21, 2023
1 of 2 checks passed
@ianmkenney ianmkenney deleted the subpage_assets branch August 21, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logo and favicon are not rendered properly on subpages
2 participants