Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors with "around" selection command in version 0.16 #1311

Closed
maxscheurer opened this issue Apr 15, 2017 · 9 comments
Closed

Errors with "around" selection command in version 0.16 #1311

maxscheurer opened this issue Apr 15, 2017 · 9 comments

Comments

@maxscheurer
Copy link

maxscheurer commented Apr 15, 2017

Expected behaviour

Correct number of atoms in selection with "around" keyword.

Actual behaviour

As of version 0.16.0, the atom selection command "around" does not yield the same
results as version 0.15 .
The results gained from the older version are in agreement with VMD's "within" selection keyword, i.e.

set sel [atomselect top "segname A and within 5 of segname B"]

Perhaps I missed something important in the Release Notes that explains this behavior...

Code to reproduce the behaviour

import MDAnalysis as mda

u = mda.Universe(top, trj)
u.select_atoms("segid A and around 5 segid B")

Currently version of MDAnalysis:

0.16.0

@richardjgowers
Copy link
Member

richardjgowers commented Apr 15, 2017 via email

@maxscheurer
Copy link
Author

maxscheurer commented Apr 15, 2017

I will try to do so asap...

@richardjgowers
Copy link
Member

@maxscheurer if it's tricky to make it not work using the test files you can also just upload a system here where you're getting different results

@orbeckst
Copy link
Member

Thanks for reporting. An example would be crucial, though.

@orbeckst
Copy link
Member

orbeckst commented May 3, 2017

@maxscheurer have you had time to look at an example?

@orbeckst
Copy link
Member

ping @maxscheurer ... we would like to look at this issue but we really need something to work with.

@maxscheurer
Copy link
Author

@orbeckst, I will try to upload something tomorrow. Thanks for the reminder!

@maxscheurer
Copy link
Author

@orbeckst, the issue seems to be fixed in MDAnalysis version 0.16.1
I tested with VMD; mda version 0.15; 0.16.0 and 0.16.1
and the latter one yields the correct result again (as VMD and mda 0.15).

@richardjgowers
Copy link
Member

Just in case this crops up later, I think what happened here wasn't actually the around selection itself, but rather the segid A selections working incorrectly in 0.16. In 0.16.1 we improved/fixed how segments were defined in a few cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants