New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port core module to pytest #1443
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
952f626
Fix test_group_traj_access.py
utkbansal 5cf1c8c
Move core to PYTEST_LIST
utkbansal 92c878f
Fix test_atom.py
utkbansal e571771
Fix test_atomgroup.py
utkbansal 4a0d977
Fix test_atomselections.py
utkbansal 00537f7
Fix test_groups.py
utkbansal a14b673
Fix test_index_dtype.py
utkbansal 91928cc
Fix test_residue.py
utkbansal 1b633ec
Fix test_residuegroup.py
utkbansal 50c2b74
Fix test_segment.py
utkbansal 4cf65e4
Fix test_segmentgroup.py
utkbansal 512b107
Fix test_topology.py
utkbansal 8d4d906
Fix test_topologyattrs.py
utkbansal 4383276
Fix test_topologyobjects.py
utkbansal f21f2e6
Fix test_universe.py
utkbansal dee83cc
Fix test_updating_atomgroup.py
utkbansal dac44c6
Get rid of staticmethods
utkbansal 7260431
Get rid of yield
utkbansal af696cc
Get rid of yield
utkbansal b673a95
Get rid of more yield based tests
utkbansal 08d8465
Get rid of another yield based test case
utkbansal 37c1d2e
Refactor
utkbansal bee262c
Remove commented out code
utkbansal 47311f9
Minor refactor
utkbansal 2e48c32
Remove useless fixture
utkbansal acf5f0e
Import fixes
utkbansal File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you double check that marking fixtures like this works? Ie does this mark then get transferred onto tests which use this fixture?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my local system, I only have the minimal dependencies, all the test methods are skipped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You run on python3? These tests will always run on Python 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's odd. I'm python 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dcd is available on python 2 as a parser. Those tests should run for you. But since we soon have a python3 DCD parser I'm not to worried if the tests are skipped but they should be run on phython2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work on Python 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@utkbansal do these tests work under python 2 now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they work now.