Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pytest Style: test_altloc.py #1464

Merged
merged 2 commits into from
Jul 10, 2017
Merged

Pytest Style: test_altloc.py #1464

merged 2 commits into from
Jul 10, 2017

Conversation

utkbansal
Copy link
Member

Refactors test_altloc.py to use pytest conventions.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@kain88-de
Copy link
Member

These tests shouldn't be in a class anymore. They are scoped through the file.

@utkbansal
Copy link
Member Author

@kain88-de I assume that we are more happy with such small PRs?

@kain88-de kain88-de merged commit 47d8016 into MDAnalysis:develop Jul 10, 2017
@kain88-de
Copy link
Member

yes smaller PRs are nicer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kain88-de kain88-de kain88-de approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@utkbansal @kain88-de