New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest Style: test_altloc.py #1464

Merged
merged 2 commits into from Jul 10, 2017

Conversation

Projects
None yet
2 participants
@utkbansal
Member

utkbansal commented Jul 10, 2017

Refactors test_altloc.py to use pytest conventions.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?
@kain88-de

This comment has been minimized.

Member

kain88-de commented Jul 10, 2017

These tests shouldn't be in a class anymore. They are scoped through the file.

@utkbansal

This comment has been minimized.

Member

utkbansal commented Jul 10, 2017

@kain88-de I assume that we are more happy with such small PRs?

@kain88-de kain88-de merged commit 47d8016 into MDAnalysis:develop Jul 10, 2017

3 checks passed

QuantifiedCode No new issues introduced.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 89.66%
Details
@kain88-de

This comment has been minimized.

Member

kain88-de commented Jul 10, 2017

yes smaller PRs are nicer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment